[12] Properly encapsulate require_once for app.php#8632
Merged
nickvergessen merged 2 commits intostable12from Mar 5, 2018
Merged
[12] Properly encapsulate require_once for app.php#8632nickvergessen merged 2 commits intostable12from
nickvergessen merged 2 commits intostable12from
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Codecov Report
@@ Coverage Diff @@
## stable12 #8632 +/- ##
==============================================
+ Coverage 53.92% 53.92% +<.01%
Complexity 22764 22764
==============================================
Files 1387 1387
Lines 87251 87251
Branches 1331 1331
==============================================
+ Hits 47050 47051 +1
+ Misses 40201 40200 -1
|
rullzer
approved these changes
Mar 2, 2018
nickvergessen
approved these changes
Mar 5, 2018
| * load a single app | ||
| * | ||
| * @param string $app | ||
| * @throws Exception |
Member
There was a problem hiding this comment.
Yes. This is another exception outside of this try catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an app has an appinfo/app.php file, that includes a variable called $app, this would lead to a type error when calling getAppInfo otherwise.
Backport of #8372